Skip to content

fix(passport): [ID-3766] cache register user promise#2652

Closed
CodeSchwert wants to merge 2 commits into
mainfrom
ID-3677/user-registration-fix
Closed

fix(passport): [ID-3766] cache register user promise#2652
CodeSchwert wants to merge 2 commits into
mainfrom
ID-3677/user-registration-fix

Conversation

@CodeSchwert
Copy link
Copy Markdown
Contributor

@CodeSchwert CodeSchwert commented Jun 10, 2025 •
edited by atlassian Bot
Loading

Hi👋, please ensure the PR title follows the below standards:

  • PR is titled with conventional commit style naming: type(scope): message. For example: feat(passport): my new feature
  • If you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities, add a ! after the type(scope), for example feat(passport)!: my new breaking feature

Summary

ID-3677

Cache user registration promise to prevent SDK sending multiple user registration requests due to app re-rendering.

Detail and impact of the change

Added

Changed

Deprecated

Removed

Fixed

Security

Anything else worth calling out?

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Jun 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 768d86d.

Command Status Duration Result
nx affected -t build,lint,test ✅ Succeeded 3m View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 1m 19s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-16 05:07:04 UTC

@CodeSchwert CodeSchwert changed the title [ID-3766] cache register user promise fix: [ID-3766] cache register user promise Jun 11, 2025
@CodeSchwert CodeSchwert marked this pull request as ready for review June 11, 2025 04:29
@CodeSchwert CodeSchwert requested a review from a team as a code owner June 11, 2025 04:29
@CodeSchwert CodeSchwert changed the title fix: [ID-3766] cache register user promise fix(passport): [ID-3766] cache register user promise Jun 11, 2025
haydenfowler
haydenfowler reviewed Jun 16, 2025
View reviewed changes
Comment thread packages/passport/sdk/src/zkEvm/zkEvmProvider.ts Outdated
@haydenfowler
Copy link
Copy Markdown
Contributor

haydenfowler commented Jun 16, 2025

The registration endpoint appears to be getting called twice from my testing:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@haydenfowler haydenfowler haydenfowler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CodeSchwert @haydenfowler